Make 'option_value' for dnsmasq optional #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of dnsmasq options - like 'no-hosts' that
do not require a value.
This change will make sure that an entry:
resource "libvirt_network" "my_net" {
...
dnsmasq_options {
options {
option_name = "no-hosts"
}
}
}
will become:
no-hosts
in the corresponding dnsmasq.conf file.
Signed-off-by: Egbert Eich <eich@suse.com>
|
Hi @dmacvicar could you have a look at this? Thanks! |
|
I will look into this after I merge the SDK v2 update. Thanks. |
|
Thanks for the PR |
@dmacvicar Thanks for merging! - A belated Xmas present ;) |
dmacvicar
pushed a commit
to jimnydev/terraform-provider-libvirt
that referenced
this pull request
Sep 28, 2024
There are a number of dnsmasq options - like 'no-hosts' that
do not require a value.
This change will make sure that an entry:
resource "libvirt_network" "my_net" {
...
dnsmasq_options {
options {
option_name = "no-hosts"
}
}
}
will become:
no-hosts
in the corresponding dnsmasq.conf file.
Signed-off-by: Egbert Eich <eich@suse.com>
* Update documentation to reflect change in dnsmasq options handling
Signed-off-by: Egbert Eich <eich@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support value-less dnsmasq options ('no-hosts') this change set makes
option_valueoptional in which caseoption_nameis inserted in the dnsmasq.conf without traling '='.While this change invalidates the separation into 'name' and 'value' to some extend, it retains compatibility.
An update to the documentation and test cases are also included.